home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 1154456183

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/sqlite-utils/issues/440#issuecomment-1154456183 https://api.github.com/repos/simonw/sqlite-utils/issues/440 1154456183 IC_kwDOCGYnMM5Ez5p3 9599 2022-06-13T21:26:55Z 2022-06-13T21:26:55Z OWNER

So I need to make a design decision here: what should sqlite-utils do with CSV files that have rows with more values than there are headings?

Some options:

  • Ignore those extra fields entirely - silently drop that data. I'm not keen on this.
  • Throw an error. The library does this already, but the error is incomprehensible - it could turn into a useful, human-readable error instead.
  • Put the data in a JSON list in a column with a known name (None is not a valid column name, so not that). This could be something like _restkey or _values_with_no_heading. This feels like a better option, but I'd need to carefully pick a name for it - and come up with an answer for the question of what to do if the CSV file being important already uses that heading name for something else.
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
1250629388  
Powered by Datasette · Queries took 0.922ms · About: github-to-sqlite