home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 1155771462

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/sqlite-utils/issues/439#issuecomment-1155771462 https://api.github.com/repos/simonw/sqlite-utils/issues/439 1155771462 IC_kwDOCGYnMM5E46xG 9599 2022-06-14T22:28:38Z 2022-06-14T22:28:38Z OWNER

Maybe this isn't a CSV field value problem - I tried this patch and didn't seem to hit the new breakpoints:

diff --git a/sqlite_utils/utils.py b/sqlite_utils/utils.py
index d2ccc5f..f1b823a 100644
--- a/sqlite_utils/utils.py
+++ b/sqlite_utils/utils.py
@@ -204,13 +204,17 @@ def _extra_key_strategy(
         # DictReader adds a 'None' key with extra row values
         if None not in row:
             yield row
-        elif ignore_extras:
+            continue
+        else:
+            breakpoint()
+        if ignore_extras:
             # ignoring row.pop(none) because of this issue:
             # https://github.com/simonw/sqlite-utils/issues/440#issuecomment-1155358637
             row.pop(None)  # type: ignore
             yield row
         elif not extras_key:
             extras = row.pop(None)  # type: ignore
+            breakpoint()
             raise RowError(
                 "Row {} contained these extra values: {}".format(row, extras)
             )
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
1250495688  
Powered by Datasette · Queries took 1.204ms · About: github-to-sqlite