issue_comments: 1179757067

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/1048#issuecomment-1179757067 https://api.github.com/repos/simonw/datasette/issues/1048 1179757067 IC_kwDOBm6k_c5GUaoL 9599 2022-07-10T16:16:19Z 2022-07-10T16:16:19Z OWNER

None of the potential solutions for that problem are particularly appealing:

  • Make these URL generation methods async - should the other ones be async too for consistency?
  • Have some kind of mechanism that calculates and caches the pks for each table somewhere which can then be accessed here without an async call
  • Require pks is passed to these methods, having been looked up elsewhere. This is a bit gross but may end up being the best solution
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 728905098