home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 1196166269

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/1773#issuecomment-1196166269 https://api.github.com/repos/simonw/datasette/issues/1773 1196166269 IC_kwDOBm6k_c5HTAx9 9599 2022-07-27T01:26:09Z 2022-07-27T01:26:09Z OWNER

So the problem here is that in generating the ?_next= next page link we need the value from the specified sort column - but we're not selecting it any more.

Possible fixes:

  • Always include the sort column in the list of columns that are selected, then filter that out before they are displayed
  • Use a second query to figure out the _sort or _sort_desc value for that last row, since we know its primary key (we always select primary keys)

Not sure which solution is more elegant. I think it might be the second one.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
1318907685  
Powered by Datasette · Queries took 1.008ms · About: github-to-sqlite