home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 1215992640

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/1780#issuecomment-1215992640 https://api.github.com/repos/simonw/datasette/issues/1780 1215992640 IC_kwDOBm6k_c5IepNA 9599 2022-08-15T23:50:02Z 2022-08-15T23:50:02Z OWNER

This is deliberate, but maybe it's a bad design decision?

Right now Datasette assumes you made a mistake if you set facet_time_limit_ms higher than sql_time_limit_ms and ignores you.

Maybe it would be better if it refused to start the server at all and showed you an error message?

``` % datasette . --setting facet_time_limit_ms 30000 Error: facet_time_limit_ms greater than sql_time_limit_ms. Try this instead:

datasette . --setting facet_time_limit_ms 30000 --setting sql_time_limit_ms 30000

```

Or perhaps running this should set both of the time limits to 30s:

datasette . --setting facet_time_limit_ms 30000

I'm nervous about doing that though as it feels like it may surprise people who only wanted to increase one of the limits.

Option 3: make it so it's possible for facets to have a greater time limit than SQL queries generally.

Maybe that's the best option? It's not surprising to people, and I think it's reasonable to implement.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
1337541526  
Powered by Datasette · Queries took 0.847ms · About: github-to-sqlite