issue_comments: 1216042605

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/1784#issuecomment-1216042605 https://api.github.com/repos/simonw/datasette/issues/1784 1216042605 IC_kwDOBm6k_c5Ie1Zt 9599 2022-08-16T01:28:46Z 2022-08-16T01:28:46Z OWNER

Do you want to write a PR for this?

Ideally I'd want this to be covered by a test, but it looks like --load-extension isn't covered by tests at all yet. It's a tricky thing to add to the unit tests because there are plenty of Python installs out there (including the one on my Mac) that don't support .enable_load_extension() at all.

So maybe a test which uses @pytest.mark.skipIf() to skip itself if the environment it is running in doesn't support that feature?

But we'd also need to bundle a compiled SQLite extension to use in the test, which would be a slightly weird thing to have in the repo.

We do have one previous example of something like that though: https://github.com/simonw/datasette/blob/main/tests/spatialite.db and the script that builds it https://github.com/simonw/datasette/blob/main/tests/build_small_spatialite_db.py

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 1339663518