home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 1247313134

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/1809#issuecomment-1247313134 https://api.github.com/repos/simonw/datasette/issues/1809 1247313134 IC_kwDOBm6k_c5KWHzu 9599 2022-09-14T21:18:46Z 2022-09-14T21:18:46Z OWNER

await_me_maybe might be tricky though, because the only place that hook is executed is here:

https://github.com/simonw/datasette/blob/8430c3bc7dd22b173c1a8c6cd7180e3b31240cd1/datasette/app.py#L348

Which is inside the Datasette.__init__ method.

To implement an await on that would need to move it somewhere else - probably here: https://github.com/simonw/datasette/blob/8430c3bc7dd22b173c1a8c6cd7180e3b31240cd1/datasette/app.py#L391-L393

But I'm not 100% confident that is always executed at the right time to ensure the Jinja environment is properly configured? I think it is, but would need to make sure.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
1373595927  
Powered by Datasette · Queries took 0.929ms · About: github-to-sqlite