home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 1271004167

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/1836#issuecomment-1271004167 https://api.github.com/repos/simonw/datasette/issues/1836 1271004167 IC_kwDOBm6k_c5LwfwH 9599 2022-10-07T01:53:05Z 2022-10-07T01:53:05Z OWNER

Oh this is interesting!

Is your hunch here that running this line is causing the file to be stored as a second layer?

https://github.com/simonw/datasette/blob/5aa359b86907d11b3ee601510775a85a90224da8/datasette/utils/init.py#L399

I guess it's possible that running a non-read-only query against the database causes one or two bytes to be changed (maybe a transaction ID or similar?)

Modifying the inspect command to use ?mode=ro seems sensible to me. Except.... it should already be opening those files in immutable mode according to this line: https://github.com/simonw/datasette/blob/eff112498ecc499323c26612d707908831446d25/datasette/cli.py#L172-L173

Here's what opening as a immutables does:

https://github.com/simonw/datasette/blob/eff112498ecc499323c26612d707908831446d25/datasette/app.py#L258-L260

https://github.com/simonw/datasette/blob/eff112498ecc499323c26612d707908831446d25/datasette/database.py#L98

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
1400374908  
Powered by Datasette · Queries took 1.056ms · About: github-to-sqlite