issue_comments: 1301638156

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/1881#issuecomment-1301638156 https://api.github.com/repos/simonw/datasette/issues/1881 1301638156 IC_kwDOBm6k_c5NlWwM 9599 2022-11-03T04:54:00Z 2022-11-03T04:54:00Z OWNER

If I have the permissions defined like this: python PERMISSIONS = ( Permission("view-instance", "vi", False, False, True), Permission("view-database", "vd", True, False, True), Permission("view-database-download", "vdd", True, False, True), Permission("view-table", "vt", True, True, True), Permission("view-query", "vq", True, True, True), Permission("insert-row", "ir", True, True, False), Permission("delete-row", "dr", True, True, False), Permission("drop-table", "dt", True, True, False), Permission("execute-sql", "es", True, False, True), Permission("permissions-debug", "pd", False, False, False), Permission("debug-menu", "dm", False, False, False), ) Instead of just calling them by their undeclared names in places like this: python await self.ds.permission_allowed( request.actor, "execute-sql", database, default=True ) On the one hand I can ditch that confusing default=True option - whether a permission is on by default becomes a characteristic of that Permission() itself, which feels much neater.

On the other hand though, plugins that introduce their own permissions - like https://datasette.io/plugins/datasette-edit-schema - will need a way to register those permissions with Datasette core. Probably another plugin hook.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 1434094365