issue_comments: 1302574330

This is affecting me a lot at the moment, on my laptop (runs fine in CI).

Here's a change to conftest.py which highlights the problem - it cause a failure the moment there are more than 5 open files according to psutil:

diff diff --git a/tests/conftest.py b/tests/conftest.py index f4638a14..21d433c1 100644 --- a/tests/conftest.py +++ b/tests/conftest.py @@ -1,6 +1,7 @@ import httpx import os import pathlib +import psutil import pytest import re import subprocess @@ -192,3 +193,8 @@ def ds_unix_domain_socket_server(tmp_path_factory): yield ds_proc, uds # Shut it down at the end of the pytest session ds_proc.terminate() + + +def pytest_runtest_teardown(item: pytest.Item) -> None: + open_files = psutil.Process().open_files() + assert len(open_files) < 5 The first error I get from this with pytest --pdb -x is here:

``` tests/test_api.py ............E

traceback >>>>>

item = <Function test_sql_time_limit>

def pytest_runtest_teardown(item: pytest.Item) -> None:
    open_files = psutil.Process().open_files()

  assert len(open_files) < 5

E AssertionError: assert 5 < 5 E + where 5 = len([popenfile(path='/private/var/folders/wr/hn3206rs1yzgq3r49bz8nvnh0000gn/T/tmpfglrt4p2/fixtures.db', fd=14), popenfile(... fd=19), popenfile(path='/private/var/folders/wr/hn3206rs1yzgq3r49bz8nvnh0000gn/T/tmphdi5b250/fixtures.dot.db', fd=20)])

/Users/simon/Dropbox/Development/datasette/tests/conftest.py:200: AssertionError

entering PDB >>>>>

PDB post_mortem (IO-capturing turned off) >>>>> /Users/simon/Dropbox/Development/datasette/tests/conftest.py(200)pytest_runtest_teardown() -> assert len(open_files) < 5 ``` That's this test:

https://github.com/simonw/datasette/blob/2ec5583629005b32cb0877786f9681c5d43ca33f/tests/test_api.py#L656-L673

Which uses this fixture:

https://github.com/simonw/datasette/blob/2ec5583629005b32cb0877786f9681c5d43ca33f/tests/fixtures.py#L228-L231

Which calls this function:

https://github.com/simonw/datasette/blob/2ec5583629005b32cb0877786f9681c5d43ca33f/tests/fixtures.py#L105-L122

So now I'm suspicious that, even though the fixture is meant to be session scoped, the way I'm using with tempfile.TemporaryDirectory() as tmpdir: is causing a whole load of files to be created and held open which are not later closed.