issue_comments: 1336099368

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/1927#issuecomment-1336099368 https://api.github.com/repos/simonw/datasette/issues/1927 1336099368 IC_kwDOBm6k_c5Po0Io 9599 2022-12-03T06:56:36Z 2022-12-03T06:56:36Z OWNER

Neither of these options make sense if you didn't pass a "pk".

My initial implementation spotted if the pk was missing and looked it up from the table, but actually I don't think that makes sense - if you know the table exists and hence don't pass the pk you should be using /-/insert or /-/upsert instead.

So maybe this work should expanded to include validation that checks if the table exists already - and if it does, confirms that the primary key (and maybe even the columns) are the same as for that existing table.

Of course if you only send row or rows then checking columns doesn't completely make sense - but we could check that the rows you have sent are equal to or a subset of the columns in the table. We could even check the column types as well, as seen in: - #1910 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 1473411197