issue_comments: 1347620733

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/pull/1940#issuecomment-1347620733 https://api.github.com/repos/simonw/datasette/issues/1940 1347620733 IC_kwDOBm6k_c5QUw99 9599 2022-12-13T01:33:06Z 2022-12-13T01:33:06Z OWNER

It's this change which triggers the failures: ```diff diff --git a/datasette/app.py b/datasette/app.py index 760063d5..defa9688 100644 --- a/datasette/app.py +++ b/datasette/app.py @@ -707,9 +707,12 @@ class Datasette: ) return crumbs

  • async def permission_allowed(self, actor, action, resource=None, default=False):
  • async def permission_allowed(self, actor, action, resource=None, default=None): """Check permissions using the permissions_allowed plugin hook""" result = None

  • Use default from registered permission, if available

  • if default is None and action in self.permissions:
  • default = self.permissions[action].default for check in pm.hook.permission_allowed( datasette=self, actor=actor, ```
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 1486011362