issue_comments: 1353690591

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/1843#issuecomment-1353690591 https://api.github.com/repos/simonw/datasette/issues/1843 1353690591 IC_kwDOBm6k_c5Qr63f 9599 2022-12-15T20:49:05Z 2022-12-15T20:49:05Z OWNER

I have a nasty feeling the cleaner solution for this would involve porting my entire test suite from def test_blah(app_client) sync functions (which work due to a @async_to_sync call in TestClient) to async def test_blah(async_fixture): functions instead.

I've been using that latter pattern for new tests (and plugin tests) for quite a while now, but I never took on the job of refactoring all of the old ones.

A search for (app_client): across the whole project currently returns 194 results which might be a reasonable target to try switching to the new pattern as a starting point.

No idea if it will have much impact on the "Too many open files" errors though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 1408757705