home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 1355313058

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/pull/1960#issuecomment-1355313058 https://api.github.com/repos/simonw/datasette/issues/1960 1355313058 IC_kwDOBm6k_c5QyG-i 9599 2022-12-16T17:53:17Z 2022-12-16T17:53:17Z OWNER

Got some surprising test failures here: https://github.com/simonw/datasette/actions/runs/3715317653/jobs/6300336626 ```

  assert response.json() == [{"id": 1, "name": "San Francisco"}]

E AssertionError: assert {'error': 'Ta...'title': None} == [{'id': 1, 'n...n Francisco'}] E Full diff: E - [{'id': 1, 'name': 'San Francisco'}] E + {'error': 'Table not found: ๐œ๐ข๐ญ๐ข๐ž๐ฌ', 'ok': False, 'status': 404, 'title': None} `` A hunch: this failure suggests that maybe the fixtures tables were not correctly created when this test run. Maybe that can happen whenpython -n auto` runs a bunch of separate processes and hence one of the tests randomly gets run in a fresh process and executes before the in-memory fixtures database has been fully populated.

I tried adding invoke_startup() to the ds_client() fixture to see if that would fix this.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
1499150951  
Powered by Datasette ยท Queries took 1.176ms ยท About: github-to-sqlite