home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 1421022917

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/sqlite-utils/issues/524#issuecomment-1421022917 https://api.github.com/repos/simonw/sqlite-utils/issues/524 1421022917 IC_kwDOCGYnMM5UsxbF 21095447 2023-02-07T16:06:03Z 2023-02-07T16:08:58Z NONE

Do you see a way to enable it without affecting existing users or bumping the major version number?

I don't see a clean solution, only extending code with a side variable that tells us we want to apply advanced types instead of basic.

it could be a similiar command like tranform-v2 --type column DATETIME or a cli option transform --adv-type column DATETIME along with a dict that contains the advanced types. Then with knowledge that we run an advanced command we take that dictionary somehow, we can wrap the current and new dictionaries by a superdict and work with it everywhere according to the knowledge. This way shouldn't affect users who are using the previous lib versions and it have to be merged in the next major one.

But this way looks a bad design, too messy.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
1572766460  
Powered by Datasette · Queries took 1.237ms · About: github-to-sqlite