home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 1489530037

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/2049#issuecomment-1489530037 https://api.github.com/repos/simonw/datasette/issues/2049 1489530037 IC_kwDOBm6k_c5YyGy1 9599 2023-03-30T00:50:30Z 2023-03-30T00:50:30Z OWNER

Two things to consider here: _shape= and _extra=.

Most of the shapes make sense, with the exception of ?_shape=object since we don't know which column we would use as a primary key.

Looking at the (undocumented) list of extras from the table view, here are the ones I think make sense:

  • count - YES
  • facet_results - no
  • facets_timed_out - no
  • suggested_facets - no
  • human_description_en - no
  • next_url - MAYBE
  • columns - YES
  • primary_keys - no
  • display_columns - YES
  • display_rows - YES
  • debug - YES?
  • request - YES
  • query - YES
  • metadata - YES
  • extras - YES
  • database - YES
  • table - no
  • database_color - no?
  • table_actions - no
  • filters - no
  • renderers - YES
  • custom_table_templates - no
  • sorted_facet_results - no
  • table_definition - no
  • view_definition - no
  • is_view - no
  • private - YES
  • expandable_columns - no
  • form_hidden_args - no

Just the YES ones:

  • count - this is new
  • columns
  • display_columns
  • display_rows
  • debug
  • request
  • query
  • metadata
  • extras
  • database
  • renderers
  • private

The count one is interesting - I think I can provide that by optionally running select count(*) from (inner query). It's a new feature though and not one I want to expose on the HTML view since it could result in poor performance - but having it as an extra that API users can opt into may make sense.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
1646734246  
Powered by Datasette · Queries took 1.64ms · About: github-to-sqlite