home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 1499467703

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/2054#issuecomment-1499467703 https://api.github.com/repos/simonw/datasette/issues/2054 1499467703 IC_kwDOBm6k_c5ZYA-3 9599 2023-04-06T18:37:22Z 2023-04-06T18:57:22Z OWNER

I've been hoping to move entirely away from class-based views, but now I'm wondering if that's the right decision given the need to support HTTP verbs.

It is cleaner to have a class that has methods for each verb, or to have a single function that can behave differently depending on the verb?

Or should I have a mechanism for dispatching to separate functions based on the verbs that isn't implemented in a base class?

The trouble with using base classes is that I've already shown that they tempt me to put logic in weird places, which makes code harder to modify later on.

The thing here is that the ONLY thing I want to use the base class for is as an HTTP verb switcher - which makes me doubt that I should risk taking on the other temptations of having a base class.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
1657861026  
Powered by Datasette · Queries took 2.232ms · About: github-to-sqlite