issue_comments: 1506179555

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/pull/2056#issuecomment-1506179555 https://api.github.com/repos/simonw/datasette/issues/2056 1506179555 IC_kwDOBm6k_c5Zxnnj 9599 2023-04-13T01:21:05Z 2023-04-13T01:22:08Z OWNER

OK, I'm sold - this is a really neat improvement.

One thing to change in the PR: right now it runs pip install --user ruff on every commit, which hits PyPI to install the package.

I prefer to avoid hitting PyPI every time, so I like to use the GitHub Actions cache. My usual pattern for that looks like this:

https://github.com/simonw/datasette/blob/5890a20c374fb0812d88c9b0ef26a838bfa06c76/.github/workflows/test-pyodide.yml#L16-L20

Then a separate command that runs pip install ... will benefit from that cache.

Are you OK to make that change?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 1661860507