issue_comments: 1506223848

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/sqlite-utils/issues/527#issuecomment-1506223848 https://api.github.com/repos/simonw/sqlite-utils/issues/527 1506223848 IC_kwDOCGYnMM5Zxybo 9599 2023-04-13T02:08:16Z 2023-04-13T02:08:16Z OWNER

I agree, this is a design flaw.

It's technically a breaking change. As such, I would need to bump to v4 to responsibly release this.

I'd rather bundle in a few more breaking changes before shipping that version.

One thing we could do here is add an extra argument to .convert() - something like this:

python table.convert(col, lambda x: x+1, skip_false=False)

This would trigger the new, improved behaviour without breaking existing code that depends on how it works at the moment.

Then in sqlite-utils 4 we can change the default of that option.

What do you think?

(I'm open to suggestions for better names for this parameter too)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 1578790070