issue_comments: 1532481862

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/sqlite-utils/issues/496#issuecomment-1532481862 https://api.github.com/repos/simonw/sqlite-utils/issues/496 1532481862 IC_kwDOCGYnMM5bV9FG 1231935 2023-05-03T05:53:26Z 2023-05-03T05:53:26Z NONE

Would love to put our heads together for improvements here.

I think anything that is argname=DEFAULT needs to be typed as argname: str | Default = DEFAULT (replacing str with the appropriate type(s)). We may be able to get clever and tie the types to that key in the _defaults dict (definitely possible in Typescript, but I'm less familiar with advanced python types).

Right now, all args are typed as Default, which means all callers get type errors.

As for table/view, given that they don't have the same methods, it would be nice to be able to get one or the other specifically.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 1393202060