issue_comments: 1683443891

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/2143#issuecomment-1683443891 https://api.github.com/repos/simonw/datasette/issues/2143 1683443891 IC_kwDOBm6k_c5kV1Cz 9599 2023-08-18T06:58:15Z 2023-08-18T06:58:15Z OWNER

Hah, that --plugin-secret thing was a messy solution I came up with to the problem that all metadata is visible at /-/metadata - so if you need to stash a secret you need a way to keep it not-visible in there!

Hence the whole $env mess: https://docs.datasette.io/en/stable/plugins.html#secret-configuration-values

json { "plugins": { "datasette-auth-github": { "client_secret": { "$env": "GITHUB_CLIENT_SECRET" } } } }

If configuration and metadata were separate we could ditch that whole messy situation - configuration can stay hidden, metadata can stay public.

Though I have been thinking that Datasette might benefit from a "secrets" mechanism that's separate from configuration and metadata... kind of like what LLM has: https://llm.datasette.io/en/stable/help.html#llm-keys-help

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 1855885427