home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 370461231

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/185#issuecomment-370461231 https://api.github.com/repos/simonw/datasette/issues/185 370461231 MDEyOklzc3VlQ29tbWVudDM3MDQ2MTIzMQ== 222245 2018-03-05T15:43:56Z 2018-03-05T15:44:27Z NONE

Yes. I think the simplest implementation is to change lines like

python metadata = self.ds.metadata.get('databases', {}).get(name, {})

to

python metadata = { **self.ds.metadata, **self.ds.metadata.get('databases', {}).get(name, {}), }

so that specified inner values overwrite outer values, but only if they exist.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
299760684  
Powered by Datasette · Queries took 0.736ms · About: github-to-sqlite