home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 379559319

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/150#issuecomment-379559319 https://api.github.com/repos/simonw/datasette/issues/150 379559319 MDEyOklzc3VlQ29tbWVudDM3OTU1OTMxOQ== 9599 2018-04-08T15:35:43Z 2018-04-08T15:35:43Z OWNER

From a code point of view, the current mechanism for _group_count makes the TableView even more complicated:

https://github.com/simonw/datasette/blob/446d47fdb005b3776bc06ad8d1f44b01fc2e938b/datasette/app.py#L644-L653

Instead, I think if _group_count is detected we should generate the SQL and then defer to self.custom_sql, like we do for canned queries:

https://github.com/simonw/datasette/blob/446d47fdb005b3776bc06ad8d1f44b01fc2e938b/datasette/app.py#L539-L541

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
276704327  
Powered by Datasette · Queries took 0.933ms · About: github-to-sqlite