home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 388625703

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/pull/257#issuecomment-388625703 https://api.github.com/repos/simonw/datasette/issues/257 388625703 MDEyOklzc3VlQ29tbWVudDM4ODYyNTcwMw== 9599 2018-05-13T13:10:09Z 2018-05-13T13:10:09Z OWNER

I'm still seeing intermittent Python 3.5 failures due to dictionary ordering differences.

https://travis-ci.org/simonw/datasette/jobs/378356802

```

  assert expected_facet_results == facet_results

E AssertionError: assert {'city': [{'c...alue': 'MI'}]} == {'city': [{'co...alue': 'MI'}]} E Omitting 1 identical items, use -vv to show E Differing items: E {'city': [{'count': 4, 'toggle_url': '_facet=state&_facet=city&state=MI&city=Detroit', 'value': 'Detroit'}]} != {'city': [{'count': 4, 'toggle_url': 'state=MI&_facet=state&_facet=city&city=Detroit', 'value': 'Detroit'}]} E Use -v to get the full diff ```

To solve these cleanly I need to be able to run Python 3.5 on my local laptop rather than relying on Travis every time.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
322591993  
Powered by Datasette · Queries took 0.978ms · About: github-to-sqlite