home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 391011268

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/272#issuecomment-391011268 https://api.github.com/repos/simonw/datasette/issues/272 391011268 MDEyOklzc3VlQ29tbWVudDM5MTAxMTI2OA== 9599 2018-05-22T14:28:12Z 2018-05-22T14:28:12Z OWNER

I think I can do this almost entirely within my existing BaseView class structure.

First, decouple the async data() methods by teaching them to take a querystring object as an argument instead of a Sanic request object. The get() method can then send that new object instead of a request.

Next teach the base class how to obey the ASGI protocol.

I should be able to get support for both Sanic and uvicorn/daphne working in the same codebase, which will make it easy to compare their performance.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
324188953  
Powered by Datasette · Queries took 1.608ms · About: github-to-sqlite