home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 405975025

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/333#issuecomment-405975025 https://api.github.com/repos/simonw/datasette/issues/333 405975025 MDEyOklzc3VlQ29tbWVudDQwNTk3NTAyNQ== 9599 2018-07-18T15:36:11Z 2018-07-18T15:40:04Z OWNER

A force_https_api_urls config option would work here - if set, Datasette will ignore the incoming protocol and always use https. The datasette deploy now command could then add that as an option passed to datasette serve.

This is the pattern which is producing incorrect URLs on Zeit Now, because the Sanic request.url property is not being correctly set.

https://github.com/simonw/datasette/blob/6e37f091edec35e2706197489f54fff5d890c63c/datasette/views/table.py#L653-L655

Suggested help text:

Always use https:// for URLs output as part of Datasette API responses

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
338768551  
Powered by Datasette · Queries took 2.207ms · About: github-to-sqlite