issue_comments: 412291327

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/188#issuecomment-412291327 https://api.github.com/repos/simonw/datasette/issues/188 412291327 MDEyOklzc3VlQ29tbWVudDQxMjI5MTMyNw== 9599 2018-08-11T17:53:17Z 2018-08-11T17:53:17Z OWNER

Potential problem: the existing metadata.json format looks like this:

{ "title": "Custom title for your index page", "description": "Some description text can go here", "license": "ODbL", "license_url": "https://opendatacommons.org/licenses/odbl/", "databases": { "database1": { "source": "Alternative source", "source_url": "http://example.com/", "tables": { "example_table": { "description_html": "Custom <em>table</em> description", "license": "CC BY 3.0 US", "license_url": "https://creativecommons.org/licenses/by/3.0/us/" } } } } }

This doesn't make sense for metadata that is bundled with a specific database - there's no point in having the databases key, instead the content of database1 in the above example should be at the top level. This also means that if you rename the *.db file you won't have to edit its metadata at the same time.

Calling such an embedded file metadata.json when the shape is different could be confusing. Maybe call it database-metadata.json instead.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 309047460