home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 451704724

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/394#issuecomment-451704724 https://api.github.com/repos/simonw/datasette/issues/394 451704724 MDEyOklzc3VlQ29tbWVudDQ1MTcwNDcyNA== 9599 2019-01-06T00:32:23Z 2019-01-06T00:33:44Z OWNER

I found a really nice pattern for writing the unit tests for this (though it would look even nicer with a solution to #395) python @pytest.mark.parametrize("prefix", ["/prefix/", "https://example.com/"]) @pytest.mark.parametrize("path", [ "/", "/fixtures", "/fixtures/compound_three_primary_keys", "/fixtures/compound_three_primary_keys/a,a,a", "/fixtures/paginated_view", ]) def test_url_prefix_config(prefix, path): for client in make_app_client(config={ "url_prefix": prefix, }): response = client.get(path) soup = Soup(response.body, "html.parser") for a in soup.findAll("a"): href = a["href"] if href not in { "https://github.com/simonw/datasette", "https://github.com/simonw/datasette/blob/master/LICENSE", "https://github.com/simonw/datasette/blob/master/tests/fixtures.py", }: assert href.startswith(prefix), (href, a.parent)

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
396212021  
Powered by Datasette · Queries took 0.79ms · About: github-to-sqlite