home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 477633354

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/420#issuecomment-477633354 https://api.github.com/repos/simonw/datasette/issues/420 477633354 MDEyOklzc3VlQ29tbWVudDQ3NzYzMzM1NA== 9599 2019-03-28T15:01:37Z 2019-03-28T15:01:37Z OWNER

I started looking at how I would implement table_exists() with a direct call that uses sqlite-utils to see if a table exists.

https://github.com/simonw/datasette/blob/82fec6048148b58748040a7e2caa163387e982a3/datasette/app.py#L303-L304

sqlite-utils needs access to the database connection - but the database connection itself is currently only available in code that runs in a thread inside the .execute() method:

https://github.com/simonw/datasette/blob/82fec6048148b58748040a7e2caa163387e982a3/datasette/app.py#L413-L426

So I'm going to need to refactor this a bit. I think I need a way to say "here is a function which needs access to the connection object for database named X - run that function in a thread, give it access to that connection and then give me back the result".

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
421971339  
Powered by Datasette · Queries took 2.771ms · About: github-to-sqlite