issue_comments: 494190922

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/272#issuecomment-494190922 https://api.github.com/repos/simonw/datasette/issues/272 494190922 MDEyOklzc3VlQ29tbWVudDQ5NDE5MDkyMg== 9599 2019-05-21T00:00:40Z 2019-05-21T00:01:09Z OWNER

Wow, this issue has been open for a full year now!

I've been thinking about this a lot. I've decided I want Datasette to use ASGI 3.0 internally with no dependencies on anything else - then I want the option to run Datasette under both daphne and uvicorn - because uvicorn doesn't support Python 3.5 but Datasette still needs to (primarily for Glitch), and daphne works with 3.5.

So I'm going to try to go the following route:

  • Every Datasette view becomes an ASGI app
  • The Datasette application itself is an ASGI app that routes to those views
  • When you pip install datasette you get Daphne as a dependency (I'd like you to be able to opt-out of installing Daphne, I'm not yet sure how that would work)
  • A new asgi_serve plugin hook allows a plugin to serve Datasette using uvicorn (or hypercorn) instead
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 324188953