issue_comments: 503195217

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/272#issuecomment-503195217 https://api.github.com/repos/simonw/datasette/issues/272 503195217 MDEyOklzc3VlQ29tbWVudDUwMzE5NTIxNw== 9599 2019-06-18T15:46:31Z 2019-06-18T15:54:18Z OWNER

How should file serving work?

Starlette and Sanic both use aiofiles - https://github.com/Tinche/aiofiles - which is a small wrapper around file operations which runs them all in an executor thread. It doesn't have any C dependencies so it looks like a good option. Quart uses it too.

aiohttp does things differently: it has an implementation based on sendfile with an alternative fallback which reads chunks from a file object and yields them one chunk at a time, 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 324188953