issue_comments: 508343359

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/pull/539#issuecomment-508343359 https://api.github.com/repos/simonw/datasette/issues/539 508343359 MDEyOklzc3VlQ29tbWVudDUwODM0MzM1OQ== 9599 2019-07-04T05:27:47Z 2019-07-04T05:27:47Z OWNER

For some reason the way I have set these tests up keeps throwing variations on this error: ``` self = <click.testing.CliRunner object at 0x7fccc0d940f0> @contextlib.contextmanager def isolated_filesystem(self): """A context manager that creates a temporary folder and changes the current working directory to it for isolated filesystem tests. """

  cwd = os.getcwd()

E FileNotFoundError: [Errno 2] No such file or directory /home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages/click/testing.py:364: FileNotFoundError After much trial and error the cause appears to be the way I was trying to create custom metadata like so:python def test_plugin_config_env(): os.environ["FOO_ENV"] = "FROM_ENVIRONMENT" for client in make_app_client( metadata={"plugins": {"env-plugin": {"foo": {"$env": "FOO_ENV"}}}} ): assert {"foo": "FROM_ENVIRONMENT"} == client.ds.plugin_config("env-plugin") del os.environ["FOO_ENV"] `` It wasnt't theos.environmanipulation OR thetempfilestuff - it appeared to be the usage ofmake_app_client(). When I stopped trying to do that (and moved my test configuration intoMETADATAin thefixtures.py` module) the tests started passing again.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 464040911