home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 549233778

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/dogsheep/github-to-sqlite/pull/8#issuecomment-549233778 https://api.github.com/repos/dogsheep/github-to-sqlite/issues/8 549233778 MDEyOklzc3VlQ29tbWVudDU0OTIzMzc3OA== 9599 2019-11-04T06:14:40Z 2019-11-04T06:14:40Z MEMBER

Spotted a tricky problem: running github-to-sqlite starred stargazers.db results in an incomplete simonw record. It creates a proper record for me thanks to this bit:

https://github.com/dogsheep/github-to-sqlite/blob/ea07274667a08c67907e8bfbbccb6f0fb95ce817/github_to_sqlite/cli.py#L120-L126

But then... when it gets to the datasette repository which I have starred it over-writes my full user record with one that's missing most of the details, thanks to this bit:

https://github.com/dogsheep/github-to-sqlite/blob/ea07274667a08c67907e8bfbbccb6f0fb95ce817/github_to_sqlite/utils.py#L117-L124

I need to find a way of NOT over-writing a good record with a thinner one.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
516763727  
Powered by Datasette · Queries took 1.053ms · About: github-to-sqlite