home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 556749086

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/394#issuecomment-556749086 https://api.github.com/repos/simonw/datasette/issues/394 556749086 MDEyOklzc3VlQ29tbWVudDU1Njc0OTA4Ng== 639012 2019-11-21T01:15:34Z 2019-11-21T01:21:45Z CONTRIBUTOR

Hey @simonw is the url_prefix config option available in another branch, it looks like you've written some tests for it above? In 0.32 I get "url_prefix is not a valid option". I think this would be really helpful!

This would be really handy for proxying datasette in another domain's subdirectory I believe this will allow folks to run upstream authentication, but the links break if the url_prefix doesn't match.

I'd prefer not to host a proxied version of datasette on a subdomain (e.g. datasette.myurl.com b/c then I gotta worry about sharing authorization cookies with the subdomain, which I just assume not do, but...)

Edit: I see the wip-url-prefix branch, I may try with that https://github.com/simonw/datasette/commit/8da2db4b71096b19e7a9ef1929369b8483d448bf

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
396212021  
Powered by Datasette · Queries took 1.231ms · About: github-to-sqlite