home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 562940252

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/649#issuecomment-562940252 https://api.github.com/repos/simonw/datasette/issues/649 562940252 MDEyOklzc3VlQ29tbWVudDU2Mjk0MDI1Mg== 9599 2019-12-08T11:59:52Z 2019-12-08T12:00:12Z OWNER

The easiest solution would be to only show counts on the index pages for immutable (-i) databases.

I don't like this, because the most common uses of Datasette don't in my opinion justify it. Most of the time Datasette will be running against a single, small, mutable database. I'd like to show counts in that case.

Some options:

  • disable counts on the index page for mutable databases of more than one is attached
  • disable counts on the index page for databases where the file in disk is larger than a specified threshold (maybe 10MB? I'm making up this number)
  • implement an overall timer which cuts off table counting once the sum of time spent on it has gone beyond a second

Worth prototyping a bit to see what works best.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
534530973  
Powered by Datasette · Queries took 2.146ms · About: github-to-sqlite