home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 563015290

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/648#issuecomment-563015290 https://api.github.com/repos/simonw/datasette/issues/648 563015290 MDEyOklzc3VlQ29tbWVudDU2MzAxNTI5MA== 9599 2019-12-09T00:18:17Z 2019-12-09T00:18:17Z OWNER

The implementation in https://github.com/simonw/datasette/commit/c5e8cd84d3ef55ed86771ac0bde0ca91d6b0e07a acts as a proof of concept. It has a big flaw though: it doesn't reuse the regular render() mechanism, which means it doesn't register custom template tags from plugins.

This is bad because it means that pages rendered in this way cannot take advantage of things like datasette-template-sql.

This means this issue is likely dependent on #577 - a documented mechanism to allow plugins to render templates.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
534492501  
Powered by Datasette · Queries took 2.286ms · About: github-to-sqlite