issue_comments: 568276310

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/577#issuecomment-568276310 https://api.github.com/repos/simonw/datasette/issues/577 568276310 MDEyOklzc3VlQ29tbWVudDU2ODI3NjMxMA== 9599 2019-12-22T16:10:31Z 2019-12-22T16:10:31Z OWNER

The code in question currently lives in BaseView.render():

https://github.com/simonw/datasette/blob/d54318fc7f2565e6121920ce1ea9cb8b700e629a/datasette/views/base.py#L106-L163

Should datasette.render_template() do exactly this, or should it be slightly different?

Plugins need the option to not pass a request object - so maybe that parameter becomes optional.

Perhaps plugins should be able to render templates without other plugins getting to inject their own variables?

Does it always make sense to dump in all of those extra template context variables?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 497171390