home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 586109032

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/pull/672#issuecomment-586109032 https://api.github.com/repos/simonw/datasette/issues/672 586109032 MDEyOklzc3VlQ29tbWVudDU4NjEwOTAzMg== 9599 2020-02-14T05:50:15Z 2020-02-14T05:50:15Z OWNER

So I need to ensure the ds.databases data structure is manipulated in a thread-safe manner.

Mainly I need to ensure that it is locked during iterations over it, then unlocked at the end.

Trickiest part is probably ensuring there is a test that proves this is working - I feel like I got lucky encountering that RuntimeError as early as I did.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
565064079  
Powered by Datasette · Queries took 0.96ms · About: github-to-sqlite