home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 586109784

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/pull/672#issuecomment-586109784 https://api.github.com/repos/simonw/datasette/issues/672 586109784 MDEyOklzc3VlQ29tbWVudDU4NjEwOTc4NA== 9599 2020-02-14T05:53:50Z 2020-02-14T05:54:21Z OWNER

... cheating like this seems to work: for name, db in list(self.ds.databases.items()): Python built-in operations are supposedly threadsafe, so in this case I can grab a copy of the list atomically (I think) and then safely iterate over it.

Seems to work in my testing. Wish I could prove it with a unit test though.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
565064079  
Powered by Datasette · Queries took 0.919ms · About: github-to-sqlite