issue_comments: 599125455

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/sqlite-utils/issues/92#issuecomment-599125455 https://api.github.com/repos/simonw/sqlite-utils/issues/92 599125455 MDEyOklzc3VlQ29tbWVudDU5OTEyNTQ1NQ== 9599 2020-03-14T19:34:35Z 2020-03-14T19:34:35Z OWNER

From https://www.sqlite.org/datatype3.html it looks like FLOAT is a supported keyword for creating tables but REAL is the correct keyword.

So actually sqlite-utils gets this wrong, because when we create a table we turn Python float values into a FLOAT column. Looks like the correct behaviour would be to turn them into a REAL column.

https://github.com/simonw/sqlite-utils/blob/43f1c6ab4e3a6b76531fb6f5447adb83d26f3971/sqlite_utils/db.py#L28-L48

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 581339961