home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 602955699

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/394#issuecomment-602955699 https://api.github.com/repos/simonw/datasette/issues/394 602955699 MDEyOklzc3VlQ29tbWVudDYwMjk1NTY5OQ== 9599 2020-03-24T01:34:06Z 2020-03-24T01:34:15Z OWNER

I don't think I'll go with the <base> solution purely because it doesn't work with JSON APIs - and there are quite a few places where Datasette APIs return URLs (for things like toggling facets - e.g. suggested_facets on https://latest.datasette.io/fixtures/facetable.json?_labels=on&_size=0 )

The good news is that if you look at the templates almost all of the URLs have been generated in Python code: https://github.com/simonw/datasette/blob/a498d0fe6590f9bdbc4faf9e0dd5faeb3b06002c/datasette/templates/table.html - so it shouldn't be too hard to fix in Python. Ideally I'd like to fix this with as few template changes as possible.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
396212021  
Powered by Datasette · Queries took 1.028ms · About: github-to-sqlite