home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 603501719

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/394#issuecomment-603501719 https://api.github.com/repos/simonw/datasette/issues/394 603501719 MDEyOklzc3VlQ29tbWVudDYwMzUwMTcxOQ== 9599 2020-03-24T20:59:28Z 2020-03-24T20:59:28Z OWNER

Here's the line I'm stuck on now:

https://github.com/simonw/datasette/blob/298a899e792ebd0cd82a5f01b613c31f19082e51/datasette/views/base.py#L417

Tricky question: do I continue to rebuild URLs based on the incoming request (on the assumption that it has been modified to the new thing) or do I expect that I may still see un-prefixed incoming requests and need to change them?

If the incoming URL paths contain the prefix, at what point do I drop that so I can run the regular URL matching code?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
396212021  
Powered by Datasette · Queries took 1.071ms · About: github-to-sqlite