issue_comments: 609456030

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/716#issuecomment-609456030 https://api.github.com/repos/simonw/datasette/issues/716 609456030 MDEyOklzc3VlQ29tbWVudDYwOTQ1NjAzMA== 9599 2020-04-05T17:52:39Z 2020-04-05T20:02:13Z OWNER

Found it. Prior to that change I passed view_name to the callbacks like this:

https://github.com/simonw/datasette/blob/286ed286b68793532c2a38436a08343b45cfbc91/datasette/views/base.py#L114-L132

I switched over to doing this:

https://github.com/simonw/datasette/blob/07e208cc6d9e901b87552c1be2854c220b3f9b6d/datasette/views/base.py#L95-L97

But forgot to pass in the optional view_name= argument to that render_template() method:

https://github.com/simonw/datasette/blob/2aaad72789c427875426673c1a43e67c86fc970e/datasette/app.py#L554-L556

Next step: write a failing test, then fix it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 594168758