home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 612727814

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/sqlite-utils/issues/99#issuecomment-612727814 https://api.github.com/repos/simonw/sqlite-utils/issues/99 612727814 MDEyOklzc3VlQ29tbWVudDYxMjcyNzgxNA== 9599 2020-04-13T03:05:04Z 2020-04-13T03:05:04Z OWNER

Bit trick from an implementation point of view this, since we want to be able to handle input that is a generator - so we can't scan through the input to validate that every dictionary has the same exact keys without consuming the entire iterator.

The alternative would be to raise an error the first time we spot a dictionary with keys that differ... but that's weird because we commit changes in batches, so we may end up only applying half of the changes before exiting with the error.

On that basis, I'm going to leave this as-is and mark this as wontfix.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
598640234  
Powered by Datasette · Queries took 1.461ms · About: github-to-sqlite