issue_comments: 636510303

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/699#issuecomment-636510303 https://api.github.com/repos/simonw/datasette/issues/699 636510303 MDEyOklzc3VlQ29tbWVudDYzNjUxMDMwMw== 9599 2020-05-31T18:35:17Z 2020-05-31T18:35:17Z OWNER

Keeping the structure of the actor dictionary completely undefined doesn't make sense if Datasette is going to ship with a default authentication mechanism for admin users.

I'm going to define a small set of required keys for the actor dictionary, and enforce them in code.

But which keys? I feel I need a unique key representing the identity of the actor, plus a key that can be displayed in the "You are logged in as X" navigation. Maybe these are the same key?

So the single required key could be id. Problem is: is that a string or an integer? Some use-cases may call for an integer, which matches to how SQLite auto incrementing primary keys work. admin is a string.

Maybe id is required, name is optional - but if name is present then the "You are logged in as..." uses that in preference to id. id has to be a string, and if you want to store integer IDs in your database you need to remember to convert them to a string in your actor_from_request implementation.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 582526961