home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 636515599

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/785#issuecomment-636515599 https://api.github.com/repos/simonw/datasette/issues/785 636515599 MDEyOklzc3VlQ29tbWVudDYzNjUxNTU5OQ== 9599 2020-05-31T19:17:43Z 2020-05-31T19:17:43Z OWNER

I previously solved this for the datasette-auth-existing-cookies plugin as described in this issue: https://github.com/simonw/datasette-auth-existing-cookies/issues/1

Concrete plan: you have to pass a secret to the class constructor. The Datasette plugin (the code in __init__.py) uses the following in order of preference (first things are most preferred):

  • A plugin configuration option called cookie_secret - which can be protected by this mechanism: https://datasette.readthedocs.io/en/stable/plugins.html#secret-configuration-values
  • A JSON configuration file in the user_state_dir file, if it exists
  • If that does not exist, a secret is generated and written to that JSON file

I originally planned to have separate support for an environment variable, but the existence of the secret configuration values mechanism means this is already handled.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
628025100  
Powered by Datasette · Queries took 0.837ms · About: github-to-sqlite