home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 643648359

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/834#issuecomment-643648359 https://api.github.com/repos/simonw/datasette/issues/834 643648359 MDEyOklzc3VlQ29tbWVudDY0MzY0ODM1OQ== 9599 2020-06-13T16:47:29Z 2020-06-13T16:47:29Z OWNER

Implementing this is proving surprisingly tricky, because of the need to be able to optionally await the returned value. It's a bit of a fiddle to get this to work within unit tests because they run in non-async functions - due to this cunning async_to_sync usage in the test client:

https://github.com/simonw/datasette/blob/b906030235efbdff536405d66078f4868ce0d3bd/tests/fixtures.py#L115-L133

I could switch to using async def test_* functions decorated with @pytest.mark.asyncio but I'd rather not re-engineer the entire test suite just for this one feature, so I'll try to find another way.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
637342551  
Powered by Datasette · Queries took 0.987ms · About: github-to-sqlite