home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 646209520

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/835#issuecomment-646209520 https://api.github.com/repos/simonw/datasette/issues/835 646209520 MDEyOklzc3VlQ29tbWVudDY0NjIwOTUyMA== 9599 2020-06-18T17:39:30Z 2020-06-18T17:40:53Z OWNER

datasette-auth-tokens could switch to using asgi_wrapper instead of actor_from_request - then it could add a scope["skip_csrf"] = True scope property to indicate that CSRF should not be protected.

Since asgi_wrapper wraps the CSRF protection middleware changes made to the scope by an asgi_wrapper will be visible to the CSRF middleware:

https://github.com/simonw/datasette/blob/d2aef9f7ef30fa20b1450cd181cf803f44fb4e21/datasette/app.py#L877-L888

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
637363686  
Powered by Datasette · Queries took 5.925ms · About: github-to-sqlite