issue_comments: 650455353

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue

html_url	issue_url	id	node_id	user	created_at	updated_at	author_association	body	reactions	issue
https://github.com/simonw/datasette/issues/842#issuecomment-650455353	https://api.github.com/repos/simonw/datasette/issues/842	650455353	MDEyOklzc3VlQ29tbWVudDY1MDQ1NTM1Mw==	9599	2020-06-26T23:55:40Z	2020-06-26T23:55:40Z	OWNER	`_request_ip` is actually quite hard to implement - should it take into account things like the `x-forwarded-for` header? It probably should - but that means it now needs a bunch of extra configuration to tell it which of those headers can be trusted in the current environment. As such I think I'll leave that for a plugin.	{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }	638212085

https://github.com/simonw/datasette/issues/842#issuecomment-650455353

https://api.github.com/repos/simonw/datasette/issues/842

650455353

MDEyOklzc3VlQ29tbWVudDY1MDQ1NTM1Mw==

9599

2020-06-26T23:55:40Z

OWNER

_request_ip is actually quite hard to implement - should it take into account things like the x-forwarded-for header?

It probably should - but that means it now needs a bunch of extra configuration to tell it which of those headers can be trusted in the current environment.

As such I think I'll leave that for a plugin.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}

638212085