issue_comments: 674450607

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/935#issuecomment-674450607 https://api.github.com/repos/simonw/datasette/issues/935 674450607 MDEyOklzc3VlQ29tbWVudDY3NDQ1MDYwNw== 9599 2020-08-15T21:50:41Z 2020-08-15T21:50:41Z OWNER

The bug is here:

https://github.com/simonw/datasette/blob/13b3b51087964d5e1a8c1cdd2495e07bdbe176b8/datasette/database.py#L89-L100

If conn = self.connect(write=True) raises an exception the entire server hangs, like this: ``` % datasette -i fixtures.db --get /
Exception in thread Thread-1: Traceback (most recent call last): File "/usr/local/opt/python@3.8/Frameworks/Python.framework/Versions/3.8/lib/python3.8/threading.py", line 932, in _bootstrap_inner self.run() File "/usr/local/opt/python@3.8/Frameworks/Python.framework/Versions/3.8/lib/python3.8/threading.py", line 870, in run self._target(self._args, *self._kwargs) File "/Users/simon/.local/share/virtualenvs/latest-datasette-with-all-plugins-PJL_Xy9e/lib/python3.8/site-packages/datasette/database.py", line 92, in _execute_writes conn = self.connect(write=True) File "/Users/simon/.local/share/virtualenvs/latest-datasette-with-all-plugins-PJL_Xy9e/lib/python3.8/site-packages/datasette/database.py", line 55, in connect assert not (write and not self.is_mutable) AssertionError

... server hangs here ... ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 679646710